xl: don't leak a lot of memory in forked process in domain_create
authorGianni Tedesco <gianni.tedesco@citrix.com>
Fri, 10 Sep 2010 17:49:49 +0000 (18:49 +0100)
committerGianni Tedesco <gianni.tedesco@citrix.com>
Fri, 10 Sep 2010 17:49:49 +0000 (18:49 +0100)
A goto statement skips over freeing data structures for no good reason.
It's not a real issue since the next step is to exit() but this cleans
up output of valgrind so that other leaks and errors can be spotted.

Signed-off-by: Gianni Tedesco <gianni.tedesco@citrix.com>
Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
tools/libxl/xl_cmdimpl.c

index d92e288ede3f6a8f3572d5060aa060ec910149e4..3cd310e09e09c3f1810297eecf03ceee38a87dfb 100644 (file)
@@ -1511,7 +1511,7 @@ start:
                 goto error_out;
             }
             ret = domid;
-            goto waitpid_out;
+            goto out;
         }
 
         rc = libxl_ctx_postfork(&ctx);